Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: ERC20Wrapper underlying variable is public #1

Merged
merged 2 commits into from
Feb 5, 2023

Conversation

kimanikelly
Copy link
Owner

Fixes OpenZeppelin#4026

Changes

  • Removed the public visibility from IERC20 immutable _underlying; and refactored it to include the _ due to linting errors.
  • Implemented the underlying() public view function to return the value of the _underlying variable.
  • Verified all unit tests pass including the ERC20Wrapper tests that reference the underlying function.

Visual Preview

Screen Shot 2023-02-04 at 9 35 43 AM

Screen Shot 2023-02-04 at 9 35 20 AM

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

Kimani Kelly added 2 commits February 4, 2023 09:12
Removed the public visibility from the underlying variable
Refactored the underlying variable to _underlying
Implemented the underlying function to return the value of the _underlying variable
@kimanikelly kimanikelly added the good first issue Good for newcomers label Feb 5, 2023
@kimanikelly kimanikelly self-assigned this Feb 5, 2023
@kimanikelly kimanikelly merged commit 8a5937b into master Feb 5, 2023
@kimanikelly kimanikelly deleted the issue-4026 branch April 13, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ERC20Wrapper underlying variable is public
1 participant